Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for nullable response types #61

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

asadali214
Copy link
Collaborator

What

This PR adds complete support for returning nullable response types using the nullableType() builder function to set the response types as nullable.

Why

Previously response handler was throwing an exception or returning '' when a response with no content is received.

Closes #60

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

N/A

Testing

Unit tests have been added to test this feature

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 requested a review from sufyankhanrao July 5, 2024 07:02
@asadali214 asadali214 self-assigned this Jul 5, 2024
@asadali214 asadali214 linked an issue Jul 5, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Jul 8, 2024

@asadali214 asadali214 merged commit 2274f10 into master Jul 8, 2024
11 checks passed
@asadali214 asadali214 deleted the 60-support-nullable-response-types branch July 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add complete support for returning nullable response types
2 participants