Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): enable repetitive validation for auth params #59

Merged
merged 1 commit into from
May 30, 2024

Conversation

asadali214
Copy link
Collaborator

What

This PR enables the repetitive validation for authentication parameters to cater for the cases where the parameter's values gets changed between API calls

Why

To enable the auto fetching/refresh oauthToken feature that updates Authorization header between API calls

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

N/A

Testing

I ran the existing tests

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 added bug Something isn't working enhancement New feature or request labels May 30, 2024
@asadali214 asadali214 requested a review from sufyankhanrao May 30, 2024 05:28
@asadali214 asadali214 self-assigned this May 30, 2024
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@asadali214 asadali214 merged commit 8c11179 into master May 30, 2024
11 checks passed
@asadali214 asadali214 deleted the auth-enable-re-validation branch December 16, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants