Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): adds and cover the utility functions for testing actual and expected responses #182

Merged
merged 42 commits into from
Jul 22, 2024
Merged

feat(test): adds and cover the utility functions for testing actual and expected responses #182

merged 42 commits into from
Jul 22, 2024

Conversation

asadali214
Copy link
Collaborator

@asadali214 asadali214 commented Jul 15, 2024 •
edited
Loading

Closes #177

MaryamAdnan3 and others added 25 commits June 27, 2024 09:17
feat(utilities): add test helper utilities
15b40fb 
closes #177
@asadali214
Merge branch 'master' of https://github.com/apimatic/apimatic-js-runtime
01ac894 
 into 177-add-test-helper-utilities-for-comparing-array-and-object
@asadali214
adds utility functions for headers matching and file retrieving
90fd6f5
@asadali214
refactor: updates dependencies
c50784d
@asadali214
feat: adds support for more types in requestBuilder.text()
f32b9a0
@asadali214
build: downgrade yarn lock file
c718239
@asadali214
refactor: check style fixes
97ca2bc
@asadali214
refactor: check style fix
b3fd863
feat: implement new utilities in test helper
27f2845 
- added new functionality for mapping tests

Resolves: #177
@asadali214
Merge branch 'master' into 177-add-test-helper-utilities-for-comparin…
7d09572 
…g-array-and-object
@asadali214
fix(schema): functionality of discriminated object
1760955
@asadali214
fix(schema): functionality of discriminated object with nullable oute…
77856b4 
…r type
fix(typescript): add string enum handling
4ff7126 
closes #177
@asadali214
Merge branch '177-add-test-helper-utilities-for-comparing-array-and-o…
6b74313 
…bject' of https://github.com/apimatic/apimatic-js-runtime into 177-add-test-helper-utilities-for-comparing-array-and-object
@asadali214
refactor: major refactoring of new requestBuilder functions
8c3eaf1
@asadali214
fix: build issue in requestBuilder
4851877
refactor(typescript): move test helper functionality in a new package
9dbf6ac 
closes #177
@asadali214
ci: updated pacakge version
cd63db5
refactor(tests): refactores test-helper tests
e510e1d
Merge branch '177-add-test-helper-utilities-for-comparing-array-and-o…
fff67d5 
…bject' of https://github.com/apimatic/apimatic-js-runtime into 177-add-test-helper-utilities-for-comparing-array-and-object
@asadali214
fix: incorrect import issue
4c4c3f9
@asadali214
refactor: formatting issues in testHelper.test
7f9683a
@asadali214
fix: isSameAsFile function
02a39ae
@asadali214
fix: stream matching tests using mock http client
84a8669
@asadali214
fix: stream fetching and matching
5085c80
@asadali214 asadali214 requested a review from MaryamAdnan3 July 15, 2024 06:11
@asadali214 asadali214 self-assigned this Jul 15, 2024
@asadali214 asadali214 linked an issue Jul 15, 2024 that may be closed by this pull request
Add test-helper utilities for comparing array and object #177
Closed
@asadali214 asadali214 added the enhancement New feature or request label Jul 15, 2024
MaryamAdnan3
MaryamAdnan3 previously requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@MaryamAdnan3 MaryamAdnan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should introduce README of test-helper package.

@asadali214 asadali214 requested a review from MaryamAdnan3 July 21, 2024 10:31
@asadali214 asadali214 requested a review from hamzamahmood July 21, 2024 15:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hamzamahmood
hamzamahmood approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@hamzamahmood hamzamahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me

@asadali214 asadali214 removed the request for review from MaryamAdnan3 July 22, 2024 10:49
@asadali214 asadali214 merged commit 2c1c60c into master Jul 22, 2024
10 checks passed
@asadali214 asadali214 deleted the 177-add-test-helper-utilities-for-comparing-array-and-object branch July 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzamahmood hamzamahmood hamzamahmood approved these changes

@MaryamAdnan3 MaryamAdnan3 MaryamAdnan3 left review comments

Assignees

@asadali214 asadali214

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test-helper utilities for comparing array and object
3 participants
@asadali214 @hamzamahmood @MaryamAdnan3