Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for handling empty responses with nullable types #181

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

asadali214
Copy link
Collaborator

What

This PR adds complete support for returning nullable response types using the nullability check using the provided schema to set the response types as nullable when content is missing.

Why

Previously response handler was throwing an exception when a response with no content is received.

Closes #180

@asadali214 asadali214 requested a review from sufyankhanrao July 8, 2024 07:03
@asadali214 asadali214 self-assigned this Jul 8, 2024
@asadali214 asadali214 linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Jul 8, 2024

@asadali214 asadali214 merged commit 7609254 into master Jul 9, 2024
10 checks passed
@asadali214 asadali214 deleted the 180-support-nullable-response-types branch July 9, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add complete support for returning nullable response types
2 participants