Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): fix lenient validation of string numbers in oneof #145

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix(schema): fix lenient validation of string numbers in oneof #145

merged 2 commits into from
Nov 29, 2023

Conversation

MaryamAdnan3
Copy link
Collaborator

closes #144

@MaryamAdnan3 MaryamAdnan3 self-assigned this Nov 29, 2023
@MaryamAdnan3 MaryamAdnan3 linked an issue Nov 29, 2023 that may be closed by this pull request
Enforce strict validation incase of type combinators cases between number and string for string based numbers. #144
Closed
bismapervaiz
bismapervaiz approved these changes Nov 29, 2023
View reviewed changes
Copy link

@bismapervaiz bismapervaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MaryamAdnan3
Copy link
Collaborator Author

we can bypass the code climate reported issues here as they are not applicable.

@MaryamAdnan3 MaryamAdnan3 merged commit 1eaa589 into master Nov 29, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bismapervaiz bismapervaiz bismapervaiz approved these changes

Assignees

@MaryamAdnan3 MaryamAdnan3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce strict validation incase of type combinators cases between number and string for string based numbers.
2 participants
@MaryamAdnan3 @bismapervaiz