T360 sql editor bug

client/modules/home/components/dashboards/presentation_mode/chart_viewer.jsx

@@ -17,6 +17,7 @@ const ChartViewer = ({ dashboard, charts, meteorMethodCall, routeTo, setChartVie
     prevArrow: <NavButton />,
     nextArrow: <NavButton right />,
   };
+
   return (
     <div
       className="chart-viewer anchor-for-click"

client/modules/publishing/components/chart.jsx

@@ -18,6 +18,7 @@ const Chart = props => {
   }
   const { viewObject: { data, chartType, dataTimeStamp, pivot }, queryObject } = chart;
   const needRedraw = !dataTimeStamp || Date.now() - dataTimeStamp < 1000;
+
   if (chartType) {
     return (
       <ChartCanvas

client/modules/workplace/actions/preview.js

@@ -38,30 +38,54 @@ export default {
     const requestId = _.uniqueId();
     const database = LocalState.get('CURRENT_DATABASE');
     LocalState.set('QUASAR_REQUEST_ID', requestId);
+
     Meteor.call('quasar.getData', database, query, requestId,
       (err, { data = [], answerId } = {}) => {
-        if (err) cb({ error: true });
+        if (err) {
+          cb({ error: true });
+        }
         else if (LocalState.get('QUASAR_REQUEST_ID') === answerId || isSingleRequest) {
           const processedData = dataProcessing.process(data, fields);
           cb({ data: processedData });
         }
       }
     );
   },
-  determineDefaultFields({ Notificator }, fields, chartType, pivot) {
-    let result;
-    if (pivot && pivot.model) {
-      const measuresId = pivot.model.values;
+
+  // todo !!!
+  // this function must be refactored in th future
+  determineDefaultFields({ Notificator, LocalState }, fields, chartType, pivot) {
+    const determineFieldsBySavedConstructors = (fieldsArr, constructors) =>
+      fieldsArr.map(field => {
+        if (constructors.dimensions.includes(field.id)) {
+          field.constructorType = 'dimensions';
+        } else if (constructors.measures.includes(field.id)) {
+          field.constructorType = 'measures';
+        }
+        return field;
+      });
+    const determineFieldsByModel = (fieldsArr, pivotModel) => {
+      const measuresId = pivotModel.values;
       let dimensionsCounter = 0;
-      fields.forEach(f => {
-        if (!~measuresId.indexOf(f.id)) {
+      return fieldsArr.map(field => {
+        if (!~measuresId.indexOf(field.id)) {
           dimensionsCounter++;
-          if (dimensionsCounter < 3) f.constructorType = 'dimensions';
+          if (dimensionsCounter < 3) field.constructorType = 'dimensions';
         } else {
-          f.constructorType = 'measures';
+          field.constructorType = 'measures';
         }
+        return field;
       });
-      result = fields;
+    };
+    const viewObj = LocalState.get('VIEW_OBJECT');
+    let result;
+
+    if (viewObj.fieldsConstructors) {
+      return determineFieldsBySavedConstructors(fields, viewObj.fieldsConstructors);
+    }
+
+    if (pivot && pivot.model) {
+      result = determineFieldsByModel(fields, pivot.model);
     } else {
       const getNeededfields = () => {
         const fieldsArray = [];
@@ -102,13 +126,14 @@ export default {
       });
       if (neededFields.filter(f => f.id).length) result = fields;
     }
+
     return result;
   },
 
   getNewChartModelFields(context, { chartType, fields }, { fieldId, isChecked, label }) {
     const checkedFieldsNumber = fields.filter(f => f.constructorType === label).length;
     const newFields = fields.map(f => _.extend(_.clone(f),
-        f.id === fieldId ? { constructorType: isChecked ? label : null } : {})
+      f.id === fieldId ? { constructorType: isChecked ? label : null } : {})
     );
     const maxCheckedFields = (() => {
       let res = chartTypeRules[chartType][label];

client/modules/workplace/actions/workplace_state.js

@@ -6,9 +6,18 @@ export default {
   setSQLQuery({ LocalState }, query) {
     const fields = LocalState.get('COLLECTION_FIELDS');
     const oldQueryObj = LocalState.get('SQL_QUERY_OBJECT');
+    const fieldsConstructors = getFieldsConstructorsType(oldQueryObj.fields);
+
+    if (fieldsConstructors) {
+      const viewObj = LocalState.get('VIEW_OBJECT');
+      viewObj.fieldsConstructors = fieldsConstructors;
+      LocalState.set('VIEW_OBJECT', viewObj);
+    }
+
     const queryObj = SQLParser.parseToQueryObject(query, fields);
     queryObj.from = oldQueryObj.from;
     queryObj.on = oldQueryObj.on;
+
     LocalState.set('SQL_QUERY_OBJECT', queryObj);
   },
 
@@ -109,3 +118,28 @@ function resetData(LocalState) {
     LocalState.set('VIEW_OBJECT', viewObj);
   }
 }
+
+function getFieldsConstructorsType(fieldsList) {
+  let isConstructorsFound = false;
+  const constructorTypes = {
+    measures: [],
+    dimensions: [],
+  };
+
+  let result = fieldsList.map((field, index) => {
+    const constructorType = field.constructorType;
+    if (constructorType) {
+      constructorTypes[constructorType].push(index);
+      isConstructorsFound = true;
+    }
+    return field;
+  });
+
+  if (isConstructorsFound) {
+    result = constructorTypes;
+  } else {
+    result = false;
+  }
+
+  return result;
+}

client/modules/workplace/components/preview/data_visualisation.jsx

@@ -22,6 +22,7 @@ class DataVisualisation extends React.Component {
       updateSQLQueryObj } = this.props;
     const { chartType } = viewObject;
     const tableHeight = `${window.innerHeight - 74}px`;
+
     return (
       <div className="data-visualisation">
         {tableType === 'simple' &&

client/modules/workplace/components/preview/preview.jsx

@@ -44,6 +44,7 @@ class Preview extends React.Component {
     const { savedQuery, queryObject, viewObject, tableType } = this.props;
     const { isQueryChanged, isLive } = this.state;
     const isFields = !_.isEmpty(queryObject.fields);
+
     return (
       <div
         className="preview-wrap"

client/modules/workplace/containers/workplace.js

@@ -12,6 +12,7 @@ export const composer = ({ context, setSQLQueryObj }, onData) => {
     const { chartType, query: savedQuery } = viewObject;
     parseCollectionFieldNames(queryObject.collectionFields);
     setSQLQueryObj(queryObject, tableType);
+
     LocalState.set('VIEW_OBJECT', viewObject);
     onData(null, { isSavedChart: true, tableType, chartType, savedQuery });
   }

lib/sql_parser.js

@@ -16,6 +16,7 @@ export default {
     };
     objectSQL.groupBy = getGroupBy(query, objectSQL.select);
     objectSQL.orderBy = getOrderBy(query, objectSQL.select);
+
     return objectSQL;
   },
   parseToQueryObject(rawQuery, fields) {
@@ -42,7 +43,7 @@ export default {
 };
 
 function getSelect(query) {
-  let select = query.match(/^\s*select\s+([\w([\])"'`.,/\s]+)from\s/i);
+  let select = query.match(/^\s*select\s+([\w([\])"'`*:&;.,/\s]+)from\s/i);
   if (!select) return { error: 'Wrong syntax: "SELECT <fields> FROM <collections>" expected' };
   select = select[1];
   const asNames = select.match(/\s+as\s+\w+/ig);
@@ -74,21 +75,25 @@ const parseQueryPartial = (partial, paramName) =>
   partial.slice(0, paramName.index).match(/(\w+)\/(\w+)/i);
 
 function getFrom(query) {
-  const from = query.match(/\sfrom\s+([\w([\])"'`.,/=<>\s]+$)/i)[1].replace(cutOff, '');
+  const matchRes = query.match(/\sfrom\s+([\w([\])"'`.,/=<>\s]+$)/im);
+  if (!matchRes) return null;
+  const from = matchRes[1].replace(cutOff, '');
   const name = getParamName(from);
   const path = parseQueryPartial(from, name);
   return { db: path[1], collection: path[2], name: name[1] };
 }
 
 function getJoin(query) {
-  const from = query.match(/\sjoin\s+([\w([\])"'`.,/=<>\s]+$)/i)[1].replace(cutOff, '');
+  const matchRes = query.match(/\sjoin\s+([\w([\])"'`.,/=<>\s]+$)/im);
+  if (!matchRes) return null;
+  const from = matchRes[1].replace(cutOff, '');
   const name = getParamName(from);
   const path = parseQueryPartial(from, name);
   return path[2];
 }
 
 function getGroupBy(query, select) {
-  let groupBy = query.match(/\sgroup by\s+([\w([\])"'`.,/=<>\s]+$)/i);
+  let groupBy = query.match(/^\s*group by\s+([\w([\])"'`*:&;.,/\s]+)/im);
   if (groupBy) {
     groupBy = groupBy[1].replace(cutOff, '')
       .replace(/\s/g, '');
@@ -119,19 +124,57 @@ function getOrderBy(query, select) {
 }
 
 function getHaving(query) {
-  let having = query.match(/\shaving\s+([\w([\])"'`.,/=<>\s]+$)/i);
+
+  let having = query.match(/^\s*having\s+([\w([\])"'`*:&;.,-<>%@=\/\s]+)limit\s/im);
   if (having) {
     having = having[1].replace(cutOff, '');
-    return parseFiltering(having);
+    having = removeBraces(having);
+    return parseHavingConditions(having);
   }
   return null;
+
+
+  function removeBraces(queryPart) {
+    let result = '';
+
+    if (isCountExist(queryPart)) {
+      const countWordINdex = getWordIndex(queryPart, 'count(');
+      const afterCountIndex = getWordIndex(queryPart, ')', countWordINdex);
+      result += removebracesWithRegex(queryPart.substr(0, countWordINdex));
+      result += queryPart.substring(countWordINdex, afterCountIndex + 1);
+      result += removeBraces(queryPart.substring(afterCountIndex + 1));
+    } else {
+      result += removebracesWithRegex(queryPart);
+    }
+    return result;
+  }
+
+  function isCountExist(queryToCheck) {
+    return queryToCheck.match(/COUNT[(]/gi);
+  }
+
+  function removebracesWithRegex(line) {
+    return line.replace(/[()]/g, '');
+  }
+
+  function getWordIndex(line, word, fromPosition = 0) {
+    let result = line.indexOf(word, fromPosition);
+    if (result === -1) {
+      result = line.indexOf(word.toUpperCase(), fromPosition);
+    }
+    return result;
+  }
 }
 
 function getWhere(query) {
-  let where = query.match(/\swhere\s+([\w([\])"'`.,/=<>\s]+$)/i);
+  let where = query.match(/\swhere\s+([\w([\])"'`.,/=<>\s]+$)/im);
   if (where) {
     where = where[1].replace(cutOff, '');
-    return parseFiltering(where);
+    const parsed = parseFiltering(where);
+    parsed.forEach( (item) => {
+      item.exp2 = item.exp2.replace(/^["]/i, '').replace(/["]$/i, '');
+    });
+    return parsed;
   }
   return null;
 }
@@ -148,6 +191,33 @@ function getOffset(query) {
   return null;
 }
 
+function parseHavingConditions(str) {
+  const filters = [];
+  const andOr = str.match(/\s+(and|or)\s+/gi);
+
+  if (andOr) {
+    let rest = str.slice();
+    andOr.forEach(item => {
+      const part = rest.slice(0, rest.indexOf(item));
+      filters.push(part);
+      rest = rest.slice(rest.indexOf(item) + item.length);
+    });
+    filters.push(rest);
+  } else {
+    filters.push(str);
+  }
+  return filters.map((filter, i) => {
+    const obj = { operator: filter.match(/(=|<>|<|>|\slike\s)/i)[1] };
+    const regex = new RegExp(`${obj.operator}([\\w([\\])"'\`*:&;%@.,-/\\s]+)`, 'i');
+    obj.exp2 = filter.match(regex)[1];
+    obj.exp1 = filter.replace(obj.operator, '').replace(obj.exp2, '').replace(/\s/g, '');
+    obj.operator = obj.operator.replace(/\s/g, '');
+    obj.exp2 = obj.exp2.replace(/^\s+|\s+$/g, '');
+    if (andOr && i < andOr.length) obj.join = andOr[i].replace(/\s/g, '');
+    return obj;
+  });
+}
+
 function parseFiltering(str) {
   const filters = [];
   const andOr = str.match(/\s+(and|or)\s+/gi);