Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no-github input option for git-cliff-release #165

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Dec 17, 2024

Passing the --no-github Action option removes all links (PR, issues...) and user mentions leading to GitHub. This can be useful for closed-source projects, where those links would result in 403 anyway.

Tested in this WCC branch.

@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 17, 2024
@barjin barjin requested a review from janbuchar December 17, 2024 13:53
@barjin barjin self-assigned this Dec 17, 2024
@github-actions github-actions bot added this to the 105th sprint - Tooling team milestone Dec 17, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 17, 2024
git-cliff-release/cliff.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

git-cliff-release/action.yaml Outdated Show resolved Hide resolved
git-cliff-release/cliff.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, don't forget to update the WCC workflows 🙂

@barjin barjin merged commit f05ba4e into main Dec 18, 2024
2 checks passed
@barjin barjin deleted the feat/no-github-changelog branch December 18, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants