Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add httpbin_url input to python unit tests workflow #154

Merged
merged 5 commits into from
Nov 15, 2024
Merged

feat: Add httpbin_url input to python unit tests workflow #154

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be989cb
Add httpbin_url input to python unit tests workflow
janbuchar Nov 15, 2024
c7c1875
Do not fail fast
janbuchar Nov 15, 2024
0586a2c
Fix
janbuchar Nov 15, 2024
f22dc4f
Actually fix
janbuchar Nov 15, 2024
2c91c4e
Use secrets instead of inputs
janbuchar Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python_integration_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
# Run this only for PRs from forks. Skip otherwise.
if: github.event.pull_request.head.repo.owner.login != 'apify' && github.ref != 'refs/heads/master'
environment:
env:
name: fork-pr-integration-tests
url: ${{ github.event.pull_request.html_url }}
steps:
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/python_unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,24 @@ name: Unit tests

on:
workflow_call:
inputs:
httpbin_url:
required: false
type: string
default: 'https://httpbin.org'
description: Used to set the HTTPBIN_URL environment variable

jobs:
unit_tests:
name: Unit tests
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest", "windows-latest"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] # All supported Python versions.
runs-on: ${{ matrix.os }}
environment:
HTTPBIN_URL: ${{ inputs.httpbin_url }}

steps:
- name: Checkout repository
Expand Down
Loading