fix: type correction #255
Open
fix: type correction #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thank you for your contribution! Once the tests are fixed (see the TS build issue), we can safely merge this. |
B4nan
requested changes
Dec 13, 2023
| uaFullVersion: string; | ||
| } | ||
|
|
||
| export interface ExtraProperties { |
There was a problem hiding this comment.
generally speaking, we prefer interfaces over types for objects, but since all the other object types here are types, lets stay consistent and change only this one to be a type
B4nan
added
the
t-tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.