fix: userAgentData.getHighEntropyValues has correct defaults (#244)

apify · Oct 24, 2023 · 3bb6922 · 3bb6922
1 parent 930ac21
commit 3bb6922
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/fingerprint-injector/src/utils.js b/packages/fingerprint-injector/src/utils.js
@@ -500,8 +500,7 @@ function overrideUserAgentData(userAgentData) {
                     const [hints] = args;
                     await target.apply(ctx, args);
 
-                    // If the codec is not in our collected data use
-                    const data = {};
+                    const data = { brands, mobile, platform };
                     hints.forEach((hint) => {
                         data[hint] = highEntropyValues[hint];
                     });

diff --git a/test/fingerprint-injector/fingerprint-injector.test.ts b/test/fingerprint-injector/fingerprint-injector.test.ts
@@ -311,6 +311,20 @@ describe('FingerprintInjector', () => {
                     expect(requestHeaders[header]).toBe(headers[header]);
                 }
             });
+
+            test('highEntropyValues contain default values', async () => {
+                // @ts-expect-error internal browser code
+                const result = await page.evaluate(() => navigator.userAgentData?.getHighEntropyValues([]));
+
+                if (name === 'Chrome') {
+                    expect(result).toHaveProperty('brands');
+                    expect(result.brands).toBeInstanceOf(Array);
+                    expect(result).toHaveProperty('mobile');
+                    expect([true, false]).toContain(result.mobile);
+                } else if (name === 'Firefox') {
+                    expect(result).toBeFalsy();
+                }
+            });
         });
     });