-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WIP] apify extra #116
base: master
Are you sure you want to change the base?
Conversation
8f3360a
to
121c794
Compare
…d not working yet)
a486669
to
41d9385
Compare
@barjin Are we still stuck on something or there wasn't the capacity to finalize? I will definitely want to polish the code once more but also would like to do it when we know how to build it :) |
feel free to review, guess it sort of fizzled out @B4nan ? btw it's been buildable since the first day, it's all kinda finished now - correctness and usability remain to be checked by someone with more actor-building expertise :) |
Hah, I didn't even realize you refactored the whole thing and added tests :) Let me just review it and we can release, good job! |
btw @barjin @B4nan I'm thinking about this one from time to time. Last year, there were only few new projects so there wasn't much need to implement any advanced functionality (and what we needed was fine to copy/paste). In the end, we can probably just keep copy-pasting for now. If we want to push this through, I think it would be better to do it right into Crawlee, the interface to Dataset is the same and it will bubble into SDK. The only other one that is used quite frequently is parallelPersistedCall (see example here) which should probably go to the SDK. The client would be cool but it doesn't understand migration which is needed in this case. |
No description provided.