Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restructuring and updating proxy section of platform docs #575

Merged
merged 22 commits into from
Jul 21, 2023

Conversation

jirimoravcik
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the 61st sprint - Platform team milestone Apr 13, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Apr 13, 2023
@jirimoravcik jirimoravcik marked this pull request as ready for review July 10, 2023 13:54
@jirimoravcik jirimoravcik requested a review from mtrunkat July 10, 2023 13:54
Copy link
Member

@mtrunkat mtrunkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR suggesting some changes plus describing 2 more changes I'd proceed before merging this

@jirimoravcik 
- I made some small adjustments on index.md and usage.md, please see the
comments
- But I think that in order to simplify our lives we should do one large
change on following 3 md files (datacenter, residential, and serp
pages):
- Let's extract the shared info from those pages and place everything to
usage.md - for example sessions are repeated there over and over and
that's not nessesary
- Let's extract the examples and put them to examples.md after usage.md
- this is because examples are basically the same and maintaining them
3x everywhere is just too much work.
   
Could you look into those 2 changes? I think that it will shrink the
size of docs and makes it much easier to maintain.

---------

Co-authored-by: Jiří Moravčík <[email protected]>
@jirimoravcik jirimoravcik requested review from mtrunkat and removed request for mtrunkat July 20, 2023 11:39
Copy link
Contributor

@TheoVasilis TheoVasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to these changes, might it be a good idea to link to this article on datacenter proxies somewhere?

https://blog.apify.com/datacenter-proxies-when-to-use-them-and-how-to-make-the-most-of-them/

sources/platform/proxy/google_serp_proxy.md Outdated Show resolved Hide resolved
sources/platform/proxy/google_serp_proxy.md Outdated Show resolved Hide resolved
sources/platform/proxy/index.md Outdated Show resolved Hide resolved
sources/platform/proxy/index.md Outdated Show resolved Hide resolved
@jirimoravcik jirimoravcik requested a review from TheoVasilis July 20, 2023 14:33
@mtrunkat mtrunkat requested review from mtrunkat and removed request for mtrunkat July 21, 2023 07:41
sources/platform/proxy/usage.md Outdated Show resolved Hide resolved
@jirimoravcik jirimoravcik requested a review from TheoVasilis July 21, 2023 08:46
@jirimoravcik jirimoravcik merged commit b706f9f into master Jul 21, 2023
@jirimoravcik jirimoravcik deleted the feature/proxy-restructuring branch July 21, 2023 09:44
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants