Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consolidate README & CONTRIBUTING & remove other READMEs #1333

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TC-MO
Copy link
Contributor

@TC-MO TC-MO commented Dec 10, 2024

No description provided.

@github-actions github-actions bot added the t-docs Issues owned by technical writing team. label Dec 10, 2024
@TC-MO TC-MO added the documentation Improvements or additions to documentation. label Dec 10, 2024
@TC-MO TC-MO requested review from B4nan and netmilk December 10, 2024 09:23
Copy link
Contributor

@netmilk netmilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing that comes to my mind is if we merge it all, we might lose documentation of the original openapi/redoc stack that is responsible for building of the openapi.yaml from all the components and for running the pre/post processors (decorators).

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated

The API reference at (<https://docs.apify.com/api/v2>) is built directly from the OpenAPI specification of our API, versioned at https://github.com/apify/openapi.
## Style guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, "writing style guide" maybe?

README.md Outdated
If you add arrows or other indicators to the screenshots, they should be red for high contrast and visibility on the light theme.
- For contribution questions, see our [Contributing Guidelines](CONTRIBUTING.md)
- For technical issues, create a GitHub issue
- For documentation feedback, use the feedback form on our documentation pages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a direct link we can add here?

README.md Outdated

If you add arrows or other indicators to the screenshots, they should be red for high contrast and visibility on the light theme.
- For contribution questions, see our [Contributing Guidelines](CONTRIBUTING.md)
- For technical issues, create a GitHub issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall there's a direct link to create new issue in a repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

README.md Outdated Show resolved Hide resolved
@TC-MO
Copy link
Contributor Author

TC-MO commented Dec 10, 2024

Ok I guess that might be an issue off the top of my head I see some solutions tho

  1. We could merge all other README's into one mark it as legacy/deprecated both in title & body and leave it for as long as we need?
  2. Leave them spread but like above mark them as legacy/deprecated.

(it kind of looks like one solution with two aproaches now...) any thoughts?

@TC-MO TC-MO requested a review from netmilk December 10, 2024 17:57
@B4nan
Copy link
Member

B4nan commented Dec 11, 2024

I don't like the idea of having "deprecated readme" somewhere, I would like to see everything contribution related in the contributing guide, including how to work with the spec file.

CONTRIBUTING.md Outdated
Comment on lines 48 to 51
```nginx
server {
listen 80;
server_name docs.apify.loc;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is misindented

CONTRIBUTING.md Outdated
Comment on lines 94 to 108
- use *Bold* for UI elements
- use **Italics** for emphasis
- use `code` for inline code, by using back-ticks (\`\`\)
- use code blocks with language specification
- usd [code tabs](https://docusaurus.io/docs/markdown-features/tabs) whenever you want to include examples of implementation in more than one language

In the title (`cardItem`), don't just give the article's name. Phrase the title in a way that answers a question or fulfills a goal the user might have.
2. Documentation elements:

For example:
- Use [admonitions](https://docusaurus.io/docs/2.x/markdown-features/admonitions) to emphasize cruciac information, available admonitions are:
- note
- tip
- info
- caution
- danger
- Use code tabs for multiple languages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels misindented too, we use 4 spaces, not 3.

Comment on lines +183 to +184
id:
description: The resource ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this as well, 4 spaces for first level but 6 spaces for second one

@TC-MO
Copy link
Contributor Author

TC-MO commented Dec 11, 2024

@netmilk are we actually missing in this version any info that is in currently scattered READMEs? I tried to go through each README and incorporate them properly into both the new README & CONTRIBUTING

I didn't find in current README any specific mentions of redocly, just how to work with OpenAPI schema, and those have been moved over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. t-docs Issues owned by technical writing team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants