Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request-queue): Update RQ listAndLock API with latest API changes #1323

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

drobnikj
Copy link
Member

@drobnikj drobnikj commented Dec 6, 2024

Update API reference based on latest changes in API.

@github-actions github-actions bot added this to the 104th sprint - Platform team milestone Dec 6, 2024
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Dec 6, 2024
@drobnikj drobnikj marked this pull request as draft December 6, 2024 14:09
@drobnikj drobnikj requested a review from fnesveda December 9, 2024 12:10
@drobnikj drobnikj requested a review from janbuchar December 9, 2024 12:12
@drobnikj drobnikj added the adhoc Ad-hoc unplanned task added during the sprint. label Dec 9, 2024
@drobnikj drobnikj marked this pull request as ready for review December 9, 2024 12:13
Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small improvement

@@ -11,7 +11,15 @@ properties:
example: 1000
queueModifiedAt:
type: string
description: The modifiedAt the queue is updated whenever the queue is modified. Modifications include adding, updating, or removing requests, as well as locking or unlocking requests in the queue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably an extra "the queue" in the first sentence if I'm reading this right. Same in RequestQueue.yaml.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I had the same comment but I forgot to send it 😅

@drobnikj drobnikj requested a review from janbuchar December 10, 2024 09:40
Co-authored-by: Jan Buchar <[email protected]>
@drobnikj drobnikj requested a review from janbuchar December 10, 2024 12:16
@drobnikj drobnikj merged commit 57b7af4 into master Dec 16, 2024
8 checks passed
@drobnikj drobnikj deleted the feat/update_rq_list_lock_head_api branch December 16, 2024 09:53
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants