Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fav icons #1159

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix: fav icons #1159

merged 2 commits into from
Aug 26, 2024

Conversation

webrdaniel
Copy link
Contributor

@webrdaniel webrdaniel commented Aug 22, 2024

Fixing missing icon in Google search (reported here https://apify.slack.com/archives/C0L33UM7Z/p1724653919054129).

Added link for the .ico format. Also keep the link to the .svg with sizes: 'any'.
Also updated the .ico to have margins (looks better in the Google search with a circular border).

Seems like we are following the Google guidelines for icons in search. But the docs also says:

A favicon isn't guaranteed in Google Search results, even if all guidelines are met.

@webrdaniel webrdaniel added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 22, 2024
@webrdaniel webrdaniel requested a review from jbartadev August 22, 2024 12:16
@webrdaniel webrdaniel self-assigned this Aug 22, 2024
@github-actions github-actions bot added this to the 96th sprint - Web Team milestone Aug 22, 2024
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Aug 22, 2024
@webrdaniel webrdaniel changed the title fix fav icons fix: fav icons Aug 22, 2024
@jbartadev jbartadev requested a review from B4nan August 26, 2024 09:56
@webrdaniel webrdaniel merged commit 59a8938 into master Aug 26, 2024
10 checks passed
@webrdaniel webrdaniel deleted the fix/favicons branch August 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants