Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): make h2 default section heading #1153

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

HonzaKirchner
Copy link
Member

All the headings on API page were h1. This PR makes sure default is h2 (Hero component renders h1)
Bug reported here

@HonzaKirchner HonzaKirchner added bug Something isn't working. documentation Improvements or additions to documentation. adhoc Ad-hoc unplanned task added during the sprint. t-c&c Team covering store and finance matters. labels Aug 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Copy link
Member

@jbartadev jbartadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HonzaKirchner HonzaKirchner merged commit e8bbc63 into master Aug 26, 2024
7 checks passed
@HonzaKirchner HonzaKirchner deleted the feature/default-section-heading branch August 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. bug Something isn't working. documentation Improvements or additions to documentation. t-c&c Team covering store and finance matters.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants