-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): add documentation for scoped API tokens #1148
Conversation
Hey folks, asking for early review. What's missing are screenshots, which I won't be able to provide before we finish the UI. However, the copy is final (= ready for review) from my PoV. Also tagged @jirimoravcik as he is only semi-familiar with the project, so he'll be able to give useful feedback if the documentation is easy to understand / sufficiently detailed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put in some temporary screenshots (either the current state, or screenshots from Figma) until we finish the full UI, so that we can already craft the docs around them. Currently the docs are missing instructions on how to create scoped tokens, and what all the various permissions are.
I also think the API page should be displayed more prominently, not just two levels deep in Integrations, where it gets a bit lost. But that's a problem for another task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'll also check when the screenshots are added
- add instructions how to create a scoped token - add some screenshots - use "note" callouts in all instances - minor copy updates
Updated the documentation:
|
Agreed with Franta that this is not necessary.
Hmm I guess. cc @TC-MO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Good job, great docs 👍
Cool, thanks for the review ❤️ Let's wait now for Kuba and for how we decide to proceed with the UI. This means that the PR will stay open for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few changes to notes & headings
Changes look good, let's wait to final design implementation. |
Uploaded new screenshots that use the new UI. Feel free to check it out @drobnikj |
Co-authored-by: Michał Olender <[email protected]>
Alright, this PR is pretty much ready. We synced with @TC-MO and made some changes together:
I resolved all the pending conversions which were related to these topics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
I merged the public release to develop today, we can manage it to prod today. |
Won't make it to today's release. Lets's merge it tomorrow. |
We're adding public facing documentation for a new feature, tokens with limited permissions, aka scoped tokens.
Full context is available in the design doc.