Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): add documentation for scoped API tokens #1148

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

tobice
Copy link
Contributor

@tobice tobice commented Aug 13, 2024

We're adding public facing documentation for a new feature, tokens with limited permissions, aka scoped tokens.

Full context is available in the design doc.

@tobice tobice self-assigned this Aug 13, 2024
@tobice tobice requested a review from TC-MO as a code owner August 13, 2024 14:31
@github-actions github-actions bot added this to the 96th sprint - Platform team milestone Aug 13, 2024
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Aug 13, 2024
@tobice
Copy link
Contributor Author

tobice commented Aug 13, 2024

Hey folks, asking for early review. What's missing are screenshots, which I won't be able to provide before we finish the UI. However, the copy is final (= ready for review) from my PoV.

Also tagged @jirimoravcik as he is only semi-familiar with the project, so he'll be able to give useful feedback if the documentation is easy to understand / sufficiently detailed.

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put in some temporary screenshots (either the current state, or screenshots from Figma) until we finish the full UI, so that we can already craft the docs around them. Currently the docs are missing instructions on how to create scoped tokens, and what all the various permissions are.

I also think the API page should be displayed more prominently, not just two levels deep in Integrations, where it gets a bit lost. But that's a problem for another task.

sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'll also check when the screenshots are added

- add instructions how to create a scoped token
- add some screenshots
- use "note" callouts in all instances
- minor copy updates
@tobice
Copy link
Contributor Author

tobice commented Aug 14, 2024

Updated the documentation:

  • Added short instructions on how to create a scoped token
  • Added 2 temporary screenshots, to be replaced with the actual ones once the UI is finished (I see no other use cases for screenshots)
  • Unified callouts to use note across the board
  • Minor copy changes

@tobice
Copy link
Contributor Author

tobice commented Aug 14, 2024

Currently the docs are missing [...], and what all the various permissions are.

Agreed with Franta that this is not necessary.

I also think the API page should be displayed more prominently, not just two levels deep in Integrations, where it gets a bit lost. But that's a problem for another task.

Hmm I guess. cc @TC-MO

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Good job, great docs 👍

@tobice
Copy link
Contributor Author

tobice commented Aug 14, 2024

Cool, thanks for the review ❤️

Let's wait now for Kuba and for how we decide to proceed with the UI. This means that the PR will stay open for a while.

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes to notes & headings

sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
sources/platform/integrations/programming/api.md Outdated Show resolved Hide resolved
@drobnikj
Copy link
Member

Changes look good, let's wait to final design implementation.

@tobice
Copy link
Contributor Author

tobice commented Aug 23, 2024

Uploaded new screenshots that use the new UI. Feel free to check it out @drobnikj

@tobice
Copy link
Contributor Author

tobice commented Aug 23, 2024

Alright, this PR is pretty much ready.

We synced with @TC-MO and made some changes together:

  • We got rid of some of the gerunds in headings
  • We kept the generic admotion titles ("Tip" / "Note") to see if people like them

I resolved all the pending conversions which were related to these topics.

@TC-MO @drobnikj feel free to take a look and approve 🙏

Copy link
Contributor

@TC-MO TC-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@drobnikj
Copy link
Member

drobnikj commented Sep 3, 2024

I merged the public release to develop today, we can manage it to prod today.
Let's merge this @tobice

@tobice
Copy link
Contributor Author

tobice commented Sep 3, 2024

Won't make it to today's release. Lets's merge it tomorrow.

@tobice tobice merged commit 6a5a8aa into master Sep 4, 2024
7 checks passed
@tobice tobice deleted the tobik/feat/add-documentation-for-scoped-tokens branch September 4, 2024 08:34
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants