-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve environment variables section #1124
Conversation
remove outdated screenshots and instructions make sure instructions reflect current state reformat md table to be more readable change doc structure and logical flow add admonitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! Are there still some internal variables that should be included? Also, we may mention the deprecated forms of some variables, for example APIFY_DEFAULT_DATASET_ID
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
updated env var tables with description to missing ones disable GeneralURL vale rule
I kind of hoped the spreadsheet was all that was missing :D |
If you put everything in the spreadsheet into the docs, then yeah, that should do it 🙂 I don't think that for example |
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
sources/platform/actors/development/programming_interface/environment_variables.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
remove outdated screenshots and instructions
make sure instructions reflect current state
reformat md table to be more readable
change doc structure and logical flow
add admonitions