Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open source landing page #1105

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

webrdaniel
Copy link
Contributor

No description provided.

@webrdaniel webrdaniel self-assigned this Jul 22, 2024
@github-actions github-actions bot added this to the 94th sprint - Web Team milestone Jul 22, 2024
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Jul 22, 2024
@jbartadev jbartadev requested review from hanatsai and removed request for HonzaTuron July 22, 2024 10:43
Copy link
Member

@hanatsai hanatsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it's beautifully done!

Copy link
Member

@jbartadev jbartadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 💯

Copy link
Contributor

@HonzaTuron HonzaTuron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship itttttt 🚀

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave this a quick look as well, i dont see anything blocking. you can ignore the failed lychee check, it will always complain about links to new pages.

headingAs="h2"
>
<div className="actorTemplates">
<ActorTemplates displayedTemplatesIds={['python-start', 'js-start', 'ts-start']} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If you want, we have a better icon for dark theme for HTTPX here: https://github.com/apify/apify-core/blob/develop/src/console/frontend/public/img/logos_other/logo_httpx.svg

@webrdaniel webrdaniel merged commit 683b64c into master Jul 24, 2024
6 of 7 checks passed
@webrdaniel webrdaniel deleted the feat/open-source-landig-page branch July 24, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants