Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added StoreCollectionClient for listing Actors in Apify store #147

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

drobnikj
Copy link
Member

@drobnikj drobnikj commented Sep 4, 2023

@github-actions github-actions bot added this to the 71st sprint - Platform team milestone Sep 4, 2023
@github-actions github-actions bot added t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. labels Sep 4, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

None of the pull request and linked issue has estimate

Copy link
Member

@fnesveda fnesveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just one typo in the docstrings

docs/docs.md Outdated Show resolved Hide resolved
docs/docs.md Outdated

* **search** (`str`, *optional*) – String to search by. The search runs on the following fields: title, name, description, username, readme.

* **sort_be** (`str`, *optional*) – Specifies the field by which to sort the results.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **sort_be** (`str`, *optional*) – Specifies the field by which to sort the results.
* **sort_by** (`str`, *optional*) – Specifies the field by which to sort the results.

@drobnikj drobnikj requested a review from vdusek September 5, 2023 08:05
@drobnikj drobnikj requested a review from fnesveda September 5, 2023 08:08
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drobnikj drobnikj merged commit 88cb4a0 into master Sep 6, 2023
@drobnikj drobnikj deleted the feat/store_search_api branch September 6, 2023 07:34
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants