Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging of HTTP requests #143

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Improve logging of HTTP requests #143

merged 1 commit into from
Aug 25, 2023

Conversation

fnesveda
Copy link
Member

There were some issues in how the requests were logged through our logger, namely:

  • the URL in the log was the URL of the resource the request was made to, but not the action on the resource (RunClient.reboot() would log URL https://api.apify.com/v2/actor-runs/RUN_ID, without the /reboot at the end)
  • ApifyClient and ApifyClientAsync had different log messages and details
  • the request attempt and method were not logged

This fixes all of that.

@fnesveda fnesveda added adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. labels Aug 25, 2023
@fnesveda fnesveda added this to the 70th sprint - Platform team milestone Aug 25, 2023
@fnesveda fnesveda self-assigned this Aug 25, 2023
github-actions[bot]

This comment was marked as resolved.

Sign in to view

vdusek
vdusek approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fnesveda fnesveda merged commit e902df6 into master Aug 25, 2023
@fnesveda fnesveda deleted the feature/improve-logging branch August 25, 2023 13:25
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vdusek vdusek vdusek approved these changes

@jirimoravcik jirimoravcik jirimoravcik approved these changes

Assignees

@fnesveda fnesveda

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
70th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@fnesveda @jirimoravcik @vdusek