protocol: parse empty block data as null #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracek
force-pushed
the
nullable-block-data
branch
4 times, most recently
from
e0eb78e to
876440f
Compare
jaipaljadeja
reviewed
Jul 2, 2024
packages/indexer/src/indexer.test.ts
Outdated
| @@ -118,4 +118,11 @@ describe("Run Test", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| const messages = generateMockMessages(); | |||
| const messages: MockStreamResponse[] = [...Array(10)].map((_, i) => ({ | |||
There was a problem hiding this comment.
I think we can use generateMockMessages() helper method here right?
fracek
force-pushed
the
nullable-block-data
branch
from
876440f to
06b7c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DNA protocol sends an empty block to signal to the client that it scanned a
block but didn't find any data.
This happens when the client sends multiple filters in one request.
This PR changes the stream definitions to:
We also extend
StreamConfigto include amergeFilterfunction that can beused to merge multiple filters into one.