fix: fallback to PD name if slack handle missing

apiaryio · Feb 25, 2019 · d319fcb · d319fcb
1 parent 278f418
commit d319fcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/pagerduty.js b/src/pagerduty.js
@@ -295,6 +295,7 @@ function getEngineersOncallForHandover(scheduleId, escalationPolicyId, done) {
     };
     scheduleInfo.entries.forEach((entry) => {
       const oncall = {
+        name: entry.user.name,
         email: entry.user.email,
         start: moment(entry.start),
         end: moment(entry.end),

diff --git a/src/reminder.js b/src/reminder.js
@@ -5,10 +5,10 @@ const slackApi = require('./slack-api');
 const pagerduty = require('./pagerduty');
 
 function formatMessageFromTemplate(templateText, data) {
-  const current = nconf.get(`slackUsers:${data.oncallEngineers.current.email}`);
-  const next = nconf.get(`slackUsers:${data.oncallEngineers.next.email}`);
+  const current = nconf.get(`slackUsers:${data.oncallEngineers.current.email}`) || data.oncallEngineers.current.name;
+  const next = nconf.get(`slackUsers:${data.oncallEngineers.next.email}`) || data.oncallEngineers.next.name;
   const compiled = _.template(templateText);
-  const outputMessage = compiled({ current, next });
+  const outputMessage = compiled({ current, next, data });
   debug('Reminder - formatMessage: ', outputMessage);
   return outputMessage;
 }