Adds ESLint #152
Adds ESLint #152
Conversation
package.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "gavel": "bin/gavel" | |||
| }, | |||
| "scripts": { | |||
| "lint": "eslint lib/**/*.js", | |||
There was a problem hiding this comment.
Good point. Added under 837df08.
I want to also add some linting in a watch mode, since the library doesn't have a compilation step, I'd like to prevent finding out about linting errors in CI. Needs to fail fast on local, while developing.
artem-zakharchenko
force-pushed
the
146-eslint
branch
2 times, most recently
from
ce18cb2 to
7505107
Compare
| { | ||
| "useTabs": false, | ||
| "semi": true, | ||
| "trailingComma": "none", |
There was a problem hiding this comment.
I do value trailing comma for git blame purposes, and I think it's also how Dredd is set up.
However, I've stumbled into issues when trailing commas in commonJS fail execution of a module in NodeJS.
There was a problem hiding this comment.
Dredd is set up to have trailing commas in objects/arrays, but not in functions. It was because of Node 6 support. Is is possible that the issues you've experienced were because of having trailing commas in function arguments and executing with Node 6?
https://github.com/apiaryio/dredd/blob/master/.eslintrc.js#L12:L20
artem-zakharchenko
force-pushed
the
146-eslint
branch
from
7505107 to
69f9a93
Compare
| { | ||
| "useTabs": false, | ||
| "semi": true, | ||
| "trailingComma": "none", |
There was a problem hiding this comment.
Dredd is set up to have trailing commas in objects/arrays, but not in functions. It was because of Node 6 support. Is is possible that the issues you've experienced were because of having trailing commas in function arguments and executing with Node 6?
https://github.com/apiaryio/dredd/blob/master/.eslintrc.js#L12:L20
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changelog
eslintconfig and npm commands (using Dredd eslint config as an example)GitHub