-
Notifications
You must be signed in to change notification settings - Fork 280
Conversation
+ addition of [prettyjson](https://github.com/rafeca/prettyjson) to `src/prettyify-response.coffee` so that body and schema objects that are of content type `application/json' are easier to read + update to how we check content type, since types such as `application/json; charset=utf-8` are valid we should not do an exact match on `application/json` and instead do an indexOf
@obihann I'm sorry we did not respond for a longer time 😰 Thanks for your work! 👍 As |
And since you're already touching the content type logic in your PR, I'd prefer if it would be able to deal also with content types such as |
@honzajavorek sure, I'll rebase this and see how it goes. I'll also try to add those content types in. |
@obihann Awesome! If I may provide hints, I'd use media-typer for the heavy lifting. |
Looking forward @obihann! Thanks a lot for all your contributions! |
I think we should incorporate this as part of #765. |
I'm very sorry we were not able to get back to this. I need to close this as we're going to work on #705 first, which requires having no pending Pull Requests. We'll get back to this proposal as soon as we're revamping the CLI reporter: #765 Thanks for all the work! I'll do my best for this contribution not to be forgotten! |
@honzajavorek Have you come back to this feature yet? |
@honzajavorek Ah okay 👍That seems like quite a large piece of work but this issue is a simple fix. If I put in a PR for this, would it be merged before #765? |
Yes, that would be nice! |
src/prettyify-response.coffee
so that body and schema objects that are of content type `application/json' are easier to readapplication/json; charset=utf-8
are valid we should not do an exact match onapplication/json
and instead do an indexOfschemaBody
to be passed through prettyjson along withschema