-
Notifications
You must be signed in to change notification settings - Fork 280
Conversation
fcf30b8
to
cd9e432
Compare
bb891b3
to
f6d6488
Compare
f6d6488
to
61c8341
Compare
Current state: Managing docs, moved to the root directory, fixing references to fixtures from |
61c8341
to
9a04883
Compare
"e2e:openapi2": "cucumber-js --world-parameters=\"{\\\"apiDescriptionFormat\\\": \\\"application/swagger+yaml\\\"}\"", | ||
"ci:lint": "npm run lint", | ||
"ci:test": "npm test", | ||
"ci:smoke": "bash ./scripts/smoke.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment is about the PR itself, but once we have dredd-transactions in the repo too, we will want to alter the smoke tests to test with the in-repo dredd-transactions.
When the time comes for this, you can take a look at how I solved similiar in API Elements where "Fury CLI" uses the local in-repo libraries as part of the smoke test: https://github.com/apiaryio/api-elements.js/blob/dbd6aafbd50fcb2fab43eae9d612561147308377/.circleci/smoke.sh
bb97ff4
to
dc12bb6
Compare
dc12bb6
to
e2a1d22
Compare
LGTM. |
@honzajavorek please note that this pull request also brings Yarn as the default package manager to Dredd. The reasoning is the support for "workspaces", which grants an ability to properly install shared dependencies between multiple packages in a monorepo. Due to that, I'd also update the docs (mainly contributing guidelines) to mention the Yarn preference. What do you think? |
For development, right? So we're talking about the "internals" page in the docs. Sure, reasonable. For Dredd users we should still recommend npm. |
Yes, of course. Publicly nothing changes, Yarn is preferred for contributing only, not to fix package managers during dependencies management and CI. Well, in that case you're right, nothing to update (except of contributing docs in a separate pull request). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experiencing a flaky test (#1519). Re-running the workflow... |
🚀 Why this change?
📝 Related issues and Pull Requests
✅ What didn't I forget?
npm run lint