Don't call parent::__construct when not needed

api-platform · Mar 6, 2015 · 42698d1 · 42698d1
1 parent 44cc80a
commit 42698d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/SchemaOrgModel/TypesGenerator.php b/src/SchemaOrgModel/TypesGenerator.php
@@ -110,6 +110,7 @@ public function generate($config)
             'fields' => [],
             'uses' => [],
             'hasConstructor' => false,
+            'parentHasConstructor' => false,
             'hasChild' => false,
             'abstract' => false,
         ];
@@ -280,6 +281,7 @@ public function generate($config)
         foreach ($classes as &$class) {
             if ($class['parent'] && isset($classes[$class['parent']])) {
                 $classes[$class['parent']]['hasChild'] = true;
+                $class['parentHasConstructor'] = $classes[$class['parent']]['hasConstructor'];
             }
 
             foreach ($class['fields'] as &$field) {

diff --git a/templates/class.php.twig b/templates/class.php.twig
@@ -43,8 +43,10 @@ use {{ use }};
 {% if config.doctrine.useCollection and class.hasConstructor %}
     public function __construct()
     {
+{% if class.parentHasConstructor %}
         parent::__construct();
 
+{% endif %}
 {% for field in class.fields %}
 {% if config.doctrine.useCollection and field.isArray and field.typeHint and not field.isEnum %}
         $this->{{ field.name }} = new ArrayCollection();