Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct fresh model values #2697

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Construct fresh model values #2697

merged 4 commits into from
Aug 16, 2023

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Aug 16, 2023

Construct fresh values when decoding a cell not in the model-value cache.

Fixes #2690

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #2697 (72913cb) into main (b989958) will decrease coverage by 0.04%.
The diff coverage is 22.22%.

❗ Current head 72913cb differs from pull request most recent head 5089837. Consider uploading reports for the commit 5089837 to get more accurate results

@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
- Coverage   78.52%   78.49%   -0.04%     
==========================================
  Files         460      460              
  Lines       15880    15879       -1     
  Branches     2566     2594      +28     
==========================================
- Hits        12470    12464       -6     
- Misses       3410     3415       +5     
Files Changed Coverage Δ
.../forsyte/apalache/tla/bmcmt/SymbStateDecoder.scala 78.22% <22.22%> (-0.98%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comment is nonblocking.

@thpani thpani enabled auto-merge August 16, 2023 13:11
@thpani thpani merged commit 4601ff8 into main Aug 16, 2023
10 checks passed
@shonfeder shonfeder deleted the th/fix-2690 branch October 23, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TBuilderTypeException: Operator SET_ENUM cannot be applied to arguments
3 participants