Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50443][SS] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider #48996

Closed
wants to merge 1 commit into from

Conversation

ericm-db
Copy link
Contributor

@ericm-db ericm-db commented Nov 27, 2024

What changes were proposed in this pull request?

There are maven errors introduced by the guava dependency in sql/core, as we use the Guava cache to store the Avro encoders, outlined in this comment: #48401 (comment)
Introduced a new constructor for the NonFateSharingCache and used this with the RocksDBStateStoreProvider.

Why are the changes needed?

To resolve maven build errors, so that the Avro change here: #48401 does not get reverted.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing unit tests are sufficient and maven build works on devbox

[INFO] Tests run: 47, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.64 s -- in test.org.apache.spark.sql.JavaDatasetSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 47, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- surefire:3.2.5:test (test) @ spark-sql_2.13 ---
[INFO] Skipping execution of surefire because it has already been run for this configuration
[INFO] 
[INFO] --- scalatest:2.2.0:test (test) @ spark-sql_2.13 ---
[INFO] ScalaTest report directory: /home/eric.marnadi/spark/sql/core/target/surefire-reports
WARNING: Using incubator modules: jdk.incubator.vector
Discovery starting.
Discovery completed in 2 seconds, 737 milliseconds.
Run starting. Expected test count is: 0
DiscoverySuite:
Run completed in 2 seconds, 765 milliseconds.
Total number of tests run: 0
Suites: completed 1, aborted 0
Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
No tests were executed.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:15 min
[INFO] Finished at: 2024-11-28T01:10:36Z
[INFO] ------------------------------------------------------------------------

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CORE label Nov 28, 2024
@HeartSaVioR HeartSaVioR changed the title [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [SPARK-50443][SS] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider Nov 28, 2024
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending CI

@ericm-db Could you please reflect the new change into title and description? You already did, thanks!

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM
pending tests
Thank you @ericm-db

@HeartSaVioR
Copy link
Contributor

CI passed. Thanks! Merging to master.

@HeartSaVioR
Copy link
Contributor

Kudos to @LuciferYang providing the better way to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants