[SPARK-50432][BUILD] Remove workaround for THRIFT-4805 #48980
+2
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyum
approved these changes
Nov 27, 2024
yaooqinn
approved these changes
Nov 27, 2024
LuciferYang
approved these changes
Nov 27, 2024
|
What is the label for this PR? |
|
@LuciferYang I'm not sure how it should be classified, maybe "Deployment"? |
|
Maybe |
pan3793
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove workaround for THRIFT-4805 in log4j2 configuration files.
Why are the changes needed?
SPARK-47018 upgrades Thrift 0.16, and THRIFT-4805 was fixed in Thrift 0.13.
Does this PR introduce any user-facing change?
Affects default logs a little.
The existing logging filter rules use a regex to filter out the noisy logs caused by THRIFT-4805, while other problems may also produce similar logs and silently be dropped, this change restores that.
How was this patch tested?
Review.
Was this patch authored or co-authored using generative AI tooling?
No.