Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8968] Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics #8969

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Nov 21, 2024

Which Issue(s) This PR Fixes

Fixes #8968

Brief Description

  1. Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics, eliminating the need to traverse consumerOffsetTable and thereby enhancing performance.

  2. Add the setConsumerOffsetManager interface to simplify external customization.

How Did You Test This Change?

…on of topics externally without the need to traverse consumerOffset
@RongtongJin RongtongJin changed the title Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics [ISSUE #8968] Introduce the clearRetryTopicWhenDeleteTopic option to enable precise external deletion of topics Nov 21, 2024
@RongtongJin RongtongJin marked this pull request as draft November 21, 2024 09:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (a8779c0) to head (13029c0).

Files with missing lines Patch % Lines
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 3 Missing ⚠️
...a/org/apache/rocketmq/broker/BrokerController.java 0.00% 2 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8969      +/-   ##
=============================================
+ Coverage      47.61%   47.64%   +0.03%     
- Complexity     11758    11762       +4     
=============================================
  Files           1304     1304              
  Lines          91188    91199      +11     
  Branches       11713    11715       +2     
=============================================
+ Hits           43418    43454      +36     
+ Misses         42391    42367      -24     
+ Partials        5379     5378       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RongtongJin RongtongJin marked this pull request as ready for review November 21, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants