Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8935] Fix behind metrics unit error in timer message store #8936

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

GenerousMan
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8935

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.58%. Comparing base (797024f) to head (5bd2381).

Files with missing lines Patch % Lines
...apache/rocketmq/store/timer/TimerMessageStore.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8936      +/-   ##
=============================================
+ Coverage      47.55%   47.58%   +0.03%     
- Complexity     11733    11742       +9     
=============================================
  Files           1304     1304              
  Lines          91058    91058              
  Branches       11675    11675              
=============================================
+ Hits           43303    43331      +28     
+ Misses         42405    42386      -19     
+ Partials        5350     5341       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lizhimins lizhimins changed the title [ISSUE #8935]fix unit error. [ISSUE #8935] Fix behind metrics unit error in timer message store Nov 19, 2024
@lizhimins lizhimins merged commit 78575af into apache:develop Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TimerMessageStore's getEnqueueBehindMillis use wrong unit
5 participants