Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8933] feat: DefaultPullConsumer add balance switch. #8934

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Nov 15, 2024

close #8933

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.57%. Comparing base (797024f) to head (ea9a3e7).

Files with missing lines Patch % Lines
...lient/impl/consumer/DefaultMQPullConsumerImpl.java 0.00% 4 Missing ⚠️
...ocketmq/client/consumer/DefaultMQPullConsumer.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8934      +/-   ##
=============================================
+ Coverage      47.55%   47.57%   +0.01%     
- Complexity     11733    11734       +1     
=============================================
  Files           1304     1304              
  Lines          91058    91066       +8     
  Branches       11675    11677       +2     
=============================================
+ Hits           43303    43324      +21     
+ Misses         42405    42394      -11     
+ Partials        5350     5348       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit 9202de3 into apache:develop Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's no need for DefaultPullConsumer to rebalance.
4 participants