Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ReaderListenerProxy will make a segfault #376

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Apr 9, 2024

Motivation

#374

Modifications

  • Add a null check for the reader in ReaderListenerProxy

Verifying this change

  • Add reader test to cover it.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd added this to the 1.11.0 milestone Apr 9, 2024
@shibd shibd self-assigned this Apr 9, 2024
@shibd shibd added the type/bug label Apr 9, 2024
@shibd shibd merged commit e3bf582 into apache:master Apr 9, 2024
12 checks passed
shibd added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants