turn off static imports format for java formatter.

[He-Pin]

refs: #723 & #593

Update: When I run the format on Windows, there are 314 files change, so better to leave it in this pr.

[mdedetrich]

I swear I mentioned this before but I guess I was writing a comment on my mobile and it was lost somewhere but I am not sure what the use of upgrading the sbt-java-formatter is if its changing the meaning of the code by incorrectly formatting imports that is forcing us to add files to the ignore list and/or using format: off/format: on. Its not just about the state of the codebase now, if contributors add/modify .java files in the future than it creates an experience that is less than ideal.

It would be far better to figure out the underlying root cause, i.e. maybe there is an option to keep the import order as it was before?

[He-Pin]

@mdedetrich There are no config for this formatter.

I was added these file to ignored-files in .sbt-java-formatter.conf , it works too.

When I ran the javafmtAll there are 314 files affected, but seems less when ran the command from Linux.

[mdedetrich]

@mdedetrich There are no config for this formatter.

Then to be frank I think we should look for another formatter. If a formatter is changing the meaning of a program and at least doesn't allow a configuration to prevent that then this is a terrible design.

@pjfanning thoughts?

[He-Pin]

@mdedetrich And seems all those tests are related with *Behavior javadsl.

[He-Pin]

@mdedetrich but as your comments in anther pr, it's a JDK 8 bug.

[mdedetrich]

@mdedetrich but as your comments in anther pr, it's a JDK 8 bug.

I don't remember saying this, can you provide a link?

[He-Pin]

@mdedetrich from #593

https://stackoverflow.com/questions/50145575/why-does-rearranging-imports-cause-compilation-to-fail might be related, in which case we should change the formatting style or add these files into ignore

[mdedetrich]

Ah right now I remember, still at odds on this because we still support JDK 8 and will likely do so for some time (especially if multi release jar module is made). Lets see what other people say

[He-Pin]

@mdedetrich I think this is fine, anther workaround is delete the static imports, by this change we can make some progress anyway

[mdedetrich]

@mdedetrich I think this is fine, anther workaround is delete the static imports, by this change we can make some progress anyway

My current stance is to actually drop it and to add sbt-java-formatter to the ignore list for scala steward until we happen to drop JDK 8.

Its not just about current code with the format: off/format: on workaround, any new code that is written in Java can be then be autoformatted to reveal this JDK 8 bug and there is no reason for us to upgrade anyways since we are stuck with "JDK 8" java style.

[He-Pin]

Okay, let's close it, and pin the sbt-java-formatter at 0.7.0.