Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LineNumberSpec because it fails after Scala 3.3.1 upgrade #683

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Update LineNumberSpec because it fails after Scala 3.3.1 upgrade #683

merged 1 commit into from
Sep 25, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Sep 25, 2023 •
edited
Loading

see #663

@pjfanning
Update LineNumberSpec.scala
39a91c5 
update test

Update LineNumberSpec.scala
He-Pin
He-Pin approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pjfanning pjfanning merged commit 15f02d6 into apache:main Sep 25, 2023
@pjfanning pjfanning deleted the line-number-test branch September 25, 2023 19:10
@pjfanning pjfanning mentioned this pull request Oct 15, 2023
Closed
@pjfanning pjfanning mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @He-Pin