chore: Try to fix Netty leak with explicit read. #1638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
tryFixNettyLeak
branch
from
a68611b to
b8716a9
Compare
|
Do local run with |
| @@ -36,7 +35,7 @@ private[netty] trait NettyHelpers { | |||
|
|
|||
| protected def onOpen(@unused ctx: ChannelHandlerContext): Unit = () | |||
|
|
|||
| protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg: ByteBuf): Unit = () | |||
| protected def onMessage(@unused ctx: ChannelHandlerContext, @unused msg: Array[Byte]): Unit = () | |||
There was a problem hiding this comment.
Is there anything special about ByteBuf ? (;I don't know about Netty
There was a problem hiding this comment.
This PR is just a Try, and will not be needed. the old code is actually right.
|
This should not be needed, the current code is right, thanks god :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #1634
Modification:
Do explicit reading instead.
Result:
Expect No leaks.
NOTE:
The code was right.
will do auto-release.