Update pins in .scala-steward.conf #1589
Conversation
pjfanning
commented
Dec 16, 2024
pjfanning
commented
- Mockito seems to be a transitive dependency so we probably don't need to pin it.
- see Update biz.aQute.bndlib to 7.1.0 #1582 also
- also allow for patch version updates on agrona
| @@ -11,6 +11,10 @@ updates.pin = [ | |||
| { groupId = "com.google.protobuf", artifactId = "protobuf-java", version = "3." } | |||
| # aeron 1.46 requires Java 17 | |||
| { groupId = "io.aeron", version = "1.45." } | |||
| # agrona 1.23 requires Java 17 | |||
| { groupId = "org.agrona", artifactId = "agrona" version = "1.22." } | |||
There was a problem hiding this comment.
I seem to remember the reason we dodn't let scala steward update agrona is because aeron and agrona are somewhat tightly coupled, so we only update agrona when we update aeron (to the exact version that aeron expects).
There was a problem hiding this comment.
the problem is that with scala steward, we might accept the aeron update and forget the agrona one - with this change, we will be warned about a new jar - we don't need to merge it but we can research if the change is a good idea
There was a problem hiding this comment.
The comments around the versions in project/Dependencies.scala seem fairly clear - but I see at https://github.com/real-logic/aeron/blob/1.45.1/build.gradle#L59 it might be less tightly coupled than I thought, so 👍 I suppose
