build issue in nightly-builds.yml #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
commented
May 17, 2024
| @@ -178,8 +178,8 @@ jobs: | |||
| sudo apt-get install graphviz | |||
| # genjavadoc does not support Scala 3.x | |||
| sbt \ | |||
| -Dpekko.genjavadoc.enabled=${{ matrix.scalaVersion != '3.3' }} \ | |||
| "+~ ${{ matrix.scalaVersion }} doc" | |||
| -Dpekko.genjavadoc.enabled=${{ matrix.scalaVersion.startsWith("3") }} \ | |||
There was a problem hiding this comment.
#1324 changed the matrix scalaVersions to be of the form 3.3.x. I think it is safer not to rely exact matches here.
There was a problem hiding this comment.
startsWith(matrix.scalaVersion, "3") ?
https://docs.github.com/en/actions/learn-github-actions/expressions#startswith
|
The workflow is not valid. .github/workflows/nightly-builds.yml (Line: 177, Col: 14): Unexpected symbol: '('. Located at position 31 within expression: matrix.scalaVersion.startsWith("3")
--
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1324
See failures in JDK11 builds in https://github.com/apache/pekko/actions/runs/9104380012/job/25028122890
The affected sbt calls only happen when Java version is 11 due to conditions in the workflow yml.