Use sbt-web 1.5.x despite staying on paradox 0.9.2 #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running CI just to make sure but I am not expecting any surprises here |
|
Oops sorry fixed formatting |
raboof
approved these changes
Feb 21, 2024
|
apache/pekko-http#486 has an exclude on sbt-paradox 0.9.2 but this doesn't. My preference is to try out the changes in https://github.com/apache/incubator-pekko-http and then when we are happy in that repo, we can copy the full set of changes to our other repos. |
This exclude is no longer necessary on the latest version of pekko-sbt-paradox because of this change apache/pekko-sbt-paradox#97. The exception here is if some other library brings in a later version of sbt-paradox/sbt-paradox-theme that overrides the 0.9.2 version which is not JDK 1.8 compatible. |
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am pretty sure this is safe since I am basically the on who maintains sbt-web and v1.5 is pretty much compatible with v1.4 API wise.
I use the same workaround in https://github.com/sbt/sbt-paradox-material-theme/blob/v0.7.0/project/plugins.sbt#L1-L3 actually
With this change I can
+Test/compilepekko and I am not hitting https://repo.scala-sbt.org/ anymore (since I have blocked it on my machine).@mdedetrich I am pretty sure this is ok to merge.