Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paradox document blank toc entry #72

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Jan 24, 2024

Refs: apache/pekko#975
Copy from: apache/pekko-sbt-paradox#87

result

Select Current Group to Java 截屏2024-01-24 10 30 24
Select Current Group to Scala 截屏2024-01-24 10 30 27

@Roiocam Roiocam changed the title fix blank toc entry fix paradox document blank toc entry Jan 24, 2024
@Roiocam
Copy link
Member Author

Roiocam commented Jan 24, 2024

@samueleresca I think after apache/pekko-sbt-paradox#86, the paradox wan't generate group.js anymore, do you think these CI need to change?

@samueleresca
Copy link
Member

Hey @Roiocam, thanks for the the help here. I think you need to change the group.js file here. To update the content folder you need to follow the manual publishing wiki. The CI simply check that the content folder has been updated locally

@Roiocam
Copy link
Member Author

Roiocam commented Jan 24, 2024

I think you need to change the group.js file here.

Thanks for the help, I mistakenly thought the script was static assets, I will fix that.

Copy link
Member

@samueleresca samueleresca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 5598c94 into apache:main Jan 24, 2024
1 check passed
@Roiocam Roiocam deleted the fix-blank-toc branch January 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants