Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sbt-github-actions #93

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add sbt-github-actions #93

merged 1 commit into from
Feb 14, 2024

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Feb 14, 2024 •
edited
Loading

So we get basic ci for test/scripted

@mdedetrich mdedetrich force-pushed the add-sbt-github-actions branch from d81e5b6 to 9ccc980 Compare February 14, 2024 12:58
@mdedetrich mdedetrich force-pushed the add-sbt-github-actions branch from 9ccc980 to 95db163 Compare February 14, 2024 13:03
pjfanning
pjfanning requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need to publish snapshot jars - see the deleted publish.yml

@mdedetrich
Copy link
Contributor Author

we still need to publish snapshot jars - see the deleted publish.yml

Fixed

pjfanning
pjfanning approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit 919e5c3 into apache:main Feb 14, 2024
10 checks passed
@mdedetrich mdedetrich deleted the add-sbt-github-actions branch February 14, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

@raboof raboof Awaiting requested review from raboof

@gmethvin gmethvin Awaiting requested review from gmethvin

@He-Pin He-Pin Awaiting requested review from He-Pin

@samueleresca samueleresca Awaiting requested review from samueleresca

@Roiocam Roiocam Awaiting requested review from Roiocam

@jxnu-liguobin jxnu-liguobin Awaiting requested review from jxnu-liguobin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @pjfanning