Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform styling in footer #83

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Uniform styling in footer #83

merged 4 commits into from
Nov 20, 2023

Conversation

samueleresca
Copy link
Member

@samueleresca samueleresca commented Nov 19, 2023 •
edited
Loading

Restyling footer:

  • Uniform font size of the theme.
  • Clear styling on different resolutions.
  • Content hasn't changed

High res footer

full_footer

Low resolution

mob_size_screen

@pjfanning
Copy link
Contributor

pjfanning commented Nov 19, 2023 •
edited
Loading

Looks good generally. I want to try it our locally before approving.

In the future, I think we might be better off moving the CSS and some other static web site files to our CDN - see #84

pjfanning
pjfanning approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samueleresca samueleresca merged commit 1d35094 into apache:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samueleresca @pjfanning