nimble/phy: Introduce common phy for nRF52 and nRF53 #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
phy-nrf5x
branch
3 times, most recently
from
bc63ea0 to
176ec7a
Compare
|
rebased on #1345 |
andrzej-kaczmarek
force-pushed
the
phy-nrf5x
branch
from
176ec7a to
4d9daba
Compare
sjanc
reviewed
Sep 12, 2022
nimble/drivers/nrf5x/src/phy_priv.h
Outdated
| @@ -67,6 +67,7 @@ void phy_fem_enable_pa(void); | |||
| #endif | |||
| #if PHY_USE_FEM_LNA | |||
| void phy_fem_enable_lna(void); | |||
| void phy_fem_disable(void); | |||
There was a problem hiding this comment.
should be under PHY_USE_FEM only
| @@ -29,3 +29,8 @@ pkg.apis: ble_driver | |||
| pkg.deps: | |||
| - nimble | |||
| - nimble/controller | |||
|
|
|||
There was a problem hiding this comment.
this will eventually use apache/mynewt-core#2869 ?
This is starting point for common phy for nRF52 and nRF53 which will make maintaining both much easier. For now this is just c&p of nrf52 phy to make changes easier to follow. Note that nrf5x phy will not support nRF51 since, apart from other differences, it does not support hardware tifs which is required for nRF51.
This moves most of code specific to nRF52 series to separate file and creates private phy APIs to call that code. The moved code is anything related to PPI: FEM, GPIO debug and PPI itself.
andrzej-kaczmarek
force-pushed
the
phy-nrf5x
branch
from
4d9daba to
81184f1
Compare
This adds code for nRF5340 net core.
This adds proper support for FEM turn on time. Max supported turn on time is 90us due to some optimizations in code, but that should be enough - we can change it later if needed.
Radio enable takes 2 ticks, so if FEM turn on time is more than that we need to account for extra tick in scheduling offset.
andrzej-kaczmarek
force-pushed
the
phy-nrf5x
branch
from
81184f1 to
2f92be6
Compare
|
@haukepetersen fyi, this needs to be updated in RIOT |
Style check summaryNo suggestions at this time! |
sjanc
approved these changes
Sep 14, 2022
|
|
||
| #if PHY_USE_FEM | ||
| void | ||
| phy_fem_init() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first cut of common nrf5x phy which works for both nRF52 and nRF53. The goal is to have the same code used on both series in order to make maintenance easier and have the same fixes and features supported.