[MRELEASE-1109] patch JDomModel #201
Conversation
| @@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends AbstractReleasePhase impl | |||
| * Regular expression pattern matching Maven expressions (i.e. references to Maven properties). | |||
| * The first group selects the property name the expression refers to. | |||
| */ | |||
| private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+)\\}"); | |||
| private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+?)\\}"); | |||
There was a problem hiding this comment.
No it isn’t: https://docs.oracle.com/javase/tutorial/essential/regex/quant.html. The latter is greedy while the former is reluctant.
| @@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends AbstractReleasePhase impl | |||
| * Regular expression pattern matching Maven expressions (i.e. references to Maven properties). | |||
| * The first group selects the property name the expression refers to. | |||
| */ | |||
| private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+)\\}"); | |||
| private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+?)\\}"); | |||
There was a problem hiding this comment.
Causes MRELEASE-1151. This caused the weekly Jenkins core release to fail on July 2, 2024. We have downgraded Maven Release Plugin to 3.0.1 in order to restore stability to our releases.
There was a problem hiding this comment.
As a workaround you could try to add configuration property <arguments>-Dchangelist=</arguments> for the maven-release-plugin
There was a problem hiding this comment.
Causes MRELEASE-1151.
As explained in #202 (review), #202 seems to resolves this issue (with one exception), and I think this PR should not have been released without also including #202. I would recommend that the next release either include #202 or revert this PR.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MRELEASE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MRELEASE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-itsto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.