Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Lucene 9.9.0 and other minor dependency bumps #337

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Dec 4, 2023

@mbien mbien marked this pull request as ready for review December 4, 2023 16:14
pom.xml Outdated Show resolved Hide resolved
@@ -268,7 +267,7 @@ under the License.
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-webapp</artifactId>
<version>9.4.51.v20230217</version>
<version>9.4.53.v20231009</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for myself: we should move off EOLd Jetty, probably can lift some code from resolver tests that also did a smooth migration in test used "server" from 9.x to 10.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. the only reason I didn't change is because I know from running my old blog on a rapsi, that Jetty 10.x changed quite a few tings internally (module system etc and even some property names of the plugin) which can break logging for example. So I didn't want to blindly bump the major version without knowing the usages very well.

 - this also switches javac source/target to release
 - didn't touch guice since it 7.0 changes namespace
@cstamas cstamas merged commit 018d117 into apache:master Dec 11, 2023
4 checks passed
@@ -94,8 +94,7 @@ under the License.

<properties>
<javaVersion>11</javaVersion>
<maven.compiler.source>${javaVersion}</maven.compiler.source>
<maven.compiler.target>${javaVersion}</maven.compiler.target>
<maven.compiler.release>${javaVersion}</maven.compiler.release>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, forgot that this should not be removed 😄

Due this in parent:
https://github.com/apache/maven-parent/blob/maven-parent-41/pom.xml#L956-L957

Hence 11 becomes "1.11", which is kinda fine so far (as javac will ignore those two when release set), but reporting craps out, so release becomes impossible. Will undo this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with cbf1b5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants