-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some extra fields in the OpenStack Network Object: #2015 #2016
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c3d5c3d
Implements: #2015
micafer 0f8b7c8
Fix
micafer d16c45c
Add also description field
micafer b98e593
Improve coverage
micafer 0ffcca8
Merge branch 'trunk' into ost_nets_extra
micafer 00f3a02
Improve coverage
micafer 0cf0634
Merge branch 'ost_nets_extra' of github.com:micafer/libcloud into ost…
micafer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
libcloud/test/compute/fixtures/openstack_v1.1/_v2_0__network_no_tags.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
"network": { | ||
"admin_state_up": true, | ||
"availability_zone_hints": [], | ||
"availability_zones": [ | ||
"nova" | ||
], | ||
"created_at": "2016-03-08T20:19:41", | ||
"dns_domain": "my-domain.org.", | ||
"id": "e4e207ac-6707-432b-82b9-244f6859c394", | ||
"ipv4_address_scope": null, | ||
"ipv6_address_scope": null, | ||
"l2_adjacency": false, | ||
"mtu": 1500, | ||
"name": "net2", | ||
"port_security_enabled": true, | ||
"project_id": "26a7980765d0414dbc1fc1f88cdb7e6e", | ||
"qos_policy_id": "bfdb6c39f71e4d44b1dfbda245c50819", | ||
"revision_number": 3, | ||
"router:external": false, | ||
"shared": false, | ||
"status": "ACTIVE", | ||
"subnets": [ | ||
"08eae331-0402-425a-923c-34f7cfe39c1b" | ||
], | ||
"tenant_id": "26a7980765d0414dbc1fc1f88cdb7e6e", | ||
"updated_at": "2016-03-08T20:19:41", | ||
"vlan_transparent": false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per codecov comment (#2016 (comment)) could you please add additional test cases so all the new code paths are covered?
This includes tests for all those fields being present and not being present (so both the explicit "if" and implicit "else" code branches are covered).
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!