Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ec2 instance types, region details, and pricing #2012

Closed

Conversation

eric-anderson
Copy link
Contributor

Changes Update ec2 instance types, region details, and pricing

Description

Files were missing recent GPU instances

  • Updated tox.ini to use python3.11 since Ubuntu 23.10 doesn't have python3.8
  • Ran: tox -escrape-ec2-sizes,scrape-ec2-prices
  • Reverted tox.ini

Status

Replace this: done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks) -- assuming nothing to do here
  • Documentation -- assuming nothing to do here
  • Tests -- only tested on python 3.11
  • ICLA (required for bigger changes) -- assuming this doesn't count as a bigger change

Updated tox.ini to use python3.11 since Ubuntu 23.10 doesn't have python3.8
Ran: tox -escrape-ec2-sizes,scrape-ec2-prices
Reverted tox.ini
@Kami Kami added this to the v3.9.0 milestone Jun 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (6f1f83d) to head (543e2a6).
Report is 5 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2012   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files         353      353           
  Lines       81305    81305           
  Branches     8565     8565           
=======================================
  Hits        67692    67692           
  Misses      10823    10823           
  Partials     2790     2790           
Files Coverage Δ
libcloud/compute/constants/ec2_instance_types.py 100.00% <ø> (ø)
...d/compute/constants/ec2_region_details_complete.py 100.00% <ø> (ø)
...ud/compute/constants/ec2_region_details_partial.py 100.00% <ø> (ø)

asfgit pushed a commit that referenced this pull request Jun 16, 2024
@Kami
Copy link
Member

Kami commented Jun 16, 2024

I re-ran the script to pull in latest data and reformatted it using black + isort - d3b979c

I also updated contribution docs to indicate that black + isort need to run after re-generating pricing data - 7779ef5

And the changes have also been merged into trunk. Thanks.

@Kami Kami closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants