Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance KubeVirtNodeDriver Compute Driver #1983

Merged
merged 18 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cb4d20d
improve KubeVirtNodeDriver.create_node & bugs fix
cdfmlr Nov 24, 2023
1fa681f
fix(KubeVirtNodeDriver): persistentVolumeClaim: disk -> disk['volume_…
cdfmlr Nov 24, 2023
13a16a6
fix(KubeVirtNodeDriver): put containerDisk (boot disk) as the first disk
cdfmlr Jan 2, 2024
51312a3
docs(compute.drivers.kubevirt): improve docstrs
cdfmlr Jan 2, 2024
e0d832b
test(KubeVirtNodeDriver): add test_create_node
cdfmlr Jan 2, 2024
a92dde7
apply tox run changes: style & doc
cdfmlr Jan 3, 2024
3aaa67d
support legacy params ex_cpu, ex_memory and the 3-tuple type of ex_ne…
cdfmlr Jan 3, 2024
37be3ba
Merge branch 'trunk' into improve-kubevirt-node-driver
Kami Apr 18, 2024
941ab1d
Merge branch 'apache:trunk' into improve-kubevirt-node-driver
cdfmlr Apr 19, 2024
fa62045
Documenting breaking changes to KubeVirt driver #1983
cdfmlr Apr 19, 2024
1874bb7
Merge branch 'trunk' into improve-kubevirt-node-driver
Kami Apr 27, 2024
0b07480
Merge branch 'trunk' into improve-kubevirt-node-driver
Kami Apr 27, 2024
f765b42
test(KubeVirtNodeDriver): covere helpers and unhappy paths
cdfmlr Jun 18, 2024
40ec5ef
refactor(KubeVirtNodeDriver): split _create_node() into multiple smal…
cdfmlr Jun 18, 2024
4c622ee
feat(KubeVirtNodeDriver): set cpu/mem requests and limits separately
cdfmlr Jun 18, 2024
f78d361
test(KubeVirtNodeDriver): cpu/mem requests and limits
cdfmlr Jun 18, 2024
44f64ea
Merge branch 'trunk' into improve-kubevirt-node-driver
Kami Jun 18, 2024
7d7c102
fix(KubeVirtNodeDriver): prevent possible YAML injections
cdfmlr Jun 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/compute/_supported_methods_main.rst
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Provider list nodes create node reboot node destroy node s
`InternetSolutions`_ yes yes yes yes yes yes yes yes yes
`Kamatera`_ yes yes yes yes yes yes yes yes yes
`KTUCloud`_ yes yes yes yes no no yes yes yes
`kubevirt`_ yes yes yes yes yes yes yes yes no
`kubevirt`_ yes yes yes yes yes yes yes yes yes
`Libvirt`_ yes no yes yes yes yes no no no
`Linode`_ yes yes yes yes yes yes yes yes no
`Maxihost`_ yes yes yes yes yes yes yes yes no
Expand Down
32 changes: 32 additions & 0 deletions docs/upgrade_notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,38 @@ Libcloud 3.9.0
If your code is using those arguments / passing them to the `create_node()`
method it needs to be updated and those arguments removed.

* [KubeVirt] Changes to the `create_node()` method:

- The `ports` argument has been renamed to `ex_ports`.
- The `ex_disks` argument has been redefined to support all volume types.

The deprecated `ex_disks` format, which only supports `PersistentVolumeClaim`,
is as follows:

.. sourcecode:: python

ex_disks=[{"bus": "", "device": "", "disk_type": "", "name": "", "claim_name": "", "size": "", "storage_class_name": "", "volume_mode": "", "access_mode": ""}]

The new format is:

.. sourcecode:: python

ex_disks=[{"bus": "", "device": "", "disk_type": "", "name": "", "volume_spec": {...}}]

Here, `volume_spec` is the `disk_type` specific settings, which aligns with the
KubeVirt user guide on disks and volumes
(https://kubevirt.io/user-guide/virtual_machines/disks_and_volumes).

For example, for PVC:

.. sourcecode:: python

ex_disks=[{ ..., "volume_spec": {{"claim_name": "", "size": "", "storage_class_name": "", "volume_mode": "", "access_mode": ""} }]

If your code uses these arguments or passes them to the `create_node()`
method, it will need to be updated accordingly.


Libcloud 3.8.0
--------------

Expand Down
Loading
Loading