-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change importSelectors to binpack style with Scalafmt 3.8 #6674
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6674 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 684 684
Lines 42282 42282
Branches 5767 5767
======================================
Misses 42282 42282 ☔ View full report in Codecov by Sentry. |
I'm surprised that |
I agree. This PR is more about a demonstration for the impact of |
d27d81b
to
762daab
Compare
07eb6eb
to
c50db64
Compare
🔍 Description
Issue References 🔗
This pull request fixes #
Describe Your Solution 🔧
Without this PR:
With this PR:
importSelectors=binpack
, wrapping the imports in{}
while satisfying the the max length of the lineimportSelectors=binpack
in Scalafmt 3.8: Forcing{}
wrapper in extra lineimportSelectors= singleLine
in Scalafmt 3.8: Forcing extra line break before last parent package name.(which is also disorder the dep groups and IDE display)
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.